Skip to content

Added missing UM boards and fixed TinyS3 product URL. #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

UnexpectedMaker
Copy link

Description:

I added the missing Unexpected Maker boards from Arduino ESP32 Core 3.x
I also fixed the broken product URL for the TinyS3 board file.

Thanks :)

@Jason2866
Copy link

@UnexpectedMaker The boards are using tinyuf2. The boards json are missing the entrys for.
See example from Adafruit https://github.com/pioarduino/platform-espressif32/blob/main/boards/adafruit_feather_esp32s3_reversetft.json
-> partition.csv and tinyuf2.bin entrys.
The entry "ldscript": "esp32xx_out.ld" is obsolete and not used since Arduino core 2.x

@Jason2866
Copy link

maybe add option board_upload.after_reset = watchdog_reset as suggested in espressif/arduino-esp32#6762 (comment) for the CDC S3 boards?
Needs testing.

@UnexpectedMaker
Copy link
Author

@Jason2866 Unlike Adafruit that only have the TinyUF2 partition, I don't and it's not the default and I'm ok with it not being used in PIO.

I'll remove the "ldscript" entry, but it seems most boards still have it in there anyway.

My boards are set to HWCDC/Serial JTAG, so the watchdog thing is not needed. If someone changes the mode in their platform.ini, they can also add the watchdog reset.

@UnexpectedMaker
Copy link
Author

Hmm, they should all have "-DARDUINO_USB_MODE=1" - but it seems that was never picked up from the Arduino Core? Or were these files never generated from that?

Signed-off-by: Seon Rozenblum <[email protected]>
@Jason2866
Copy link

boards.json are all "handmade" That's why so many have missing entrys or the obsolete "ldscript" entry. Copy&Paste... Platformio crew never really checked the provided PRs for the boards. Anyways it will be always a mess as long boards are available with same name and different MCU configuration

@Jason2866 Jason2866 merged commit aa5a97e into pioarduino:develop Mar 10, 2025
@UnexpectedMaker
Copy link
Author

boards.json are all "handmade" That's why so many have missing entrys or the obsolete "ldscript" entry. Copy&Paste... Platformio crew never really checked the provided PRs for the boards. Anyways it will be always a mess as long boards are available with same name and different MCU configuration

Wow, I never realized - I would have kept up with adding my boards here and keep them updated if I had know. I assumed they came from the Arduino Core.

Thanks for the help and guidance @Jason2866 :)

@Jason2866
Copy link

Jason2866 commented Mar 10, 2025

@UnexpectedMaker Just noticed after hitting the merge button. When tinyuf is not used this entrys should be removed.

    "use_1200bps_touch": true,
    "wait_for_upload_port": true,

@UnexpectedMaker
Copy link
Author

Ok, nps, I'll get those updated tomorrow when I get into work - late here now - Zzzzz time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants